Skip to content

Improve TLS-related rabbitmq.conf settings of amqp_client#15772

Merged
michaelklishin merged 2 commits intomainfrom
rabbitmq-server-15767
Mar 18, 2026
Merged

Improve TLS-related rabbitmq.conf settings of amqp_client#15772
michaelklishin merged 2 commits intomainfrom
rabbitmq-server-15767

Conversation

@michaelklishin
Copy link
Copy Markdown
Collaborator

@michaelklishin michaelklishin commented Mar 18, 2026 •
edited
Loading

This is #15767 by @lukebakken with some tweaks from me:

  1. A few places quietly returned undefined instead of using cuttlefish:unset/0
  2. The SNI key used cuttlefish:unset/0 where it should have used disable when the value is set to none in rabbitmq.conf (the current behavior ends up deriving the SNI from the local hostname (a dubious behavior in the Erlang/OTP's ssl or inet apps if you ask me)
  3. Added a bunch of config_schema_SUITE test cases for less commonly used TLS-related keys

References

  1. cuttlefish tls schema for amqp_client #11415
  2. Revert "cuttlefish tls schema for amqp_client" #11531
  3. Re-submit cuttlefish tls schema for amqp_client #15767

@michaelklishin michaelklishin added this to the 4.4.0 milestone Mar 18, 2026
@michaelklishin michaelklishin mentioned this pull request Mar 18, 2026
Merged
@michaelklishin michaelklishin merged commit 0d24b7a into main Mar 18, 2026
184 checks passed
@michaelklishin michaelklishin deleted the rabbitmq-server-15767 branch March 18, 2026 23:05
@mergify mergify Bot mentioned this pull request Mar 18, 2026
Merged
michaelklishin added a commit that referenced this pull request Mar 18, 2026
@michaelklishin
Merge pull request #15773 from rabbitmq/mergify/bp/v4.3.x/pr-15772
be9e0ee 
Improve TLS-related `rabbitmq.conf` settings of `amqp_client` (backport #15772)
@mergify mergify Bot mentioned this pull request Mar 18, 2026
Merged
michaelklishin added a commit that referenced this pull request Mar 19, 2026
@michaelklishin
Merge pull request #15774 from rabbitmq/mergify/bp/v4.2.x/pr-15773
62edf4f 
Improve TLS-related `rabbitmq.conf` settings of `amqp_client` (backport #15772) (backport #15773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport-v4.2.x backport-v4.3.x

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelklishin @lukebakken
⚡